Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http): avoid unnecessary router params vec expansion #508

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(http): avoid unnecessary router params vec expansion #508

merged 1 commit into from
Oct 11, 2024

Conversation

StellarisW
Copy link
Member

Motivation

当路由参数变量为空时，仍然会对 ServerContext 下的 params Vec 数组进行扩容

Solution

对路由参数变量进行判空，不为空才扩容

@StellarisW StellarisW requested review from a team as code owners October 11, 2024 03:19
@yukiiiteru yukiiiteru merged commit c7e4fc8 into main Oct 11, 2024
8 of 16 checks passed
@yukiiiteru yukiiiteru deleted the perf/avoid_unecessary_router_params_vec_expansion branch October 11, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukiiiteru yukiiiteru yukiiiteru approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StellarisW @yukiiiteru